Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing broken tests #2126 #2127

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Fixing broken tests #2126 #2127

merged 1 commit into from
Mar 28, 2019

Conversation

mikegrima
Copy link
Collaborator

@mikegrima mikegrima commented Mar 25, 2019 •
edited
Loading

  • KMS
  • S3
  • CloudFormation

@mikegrima
Copy link
Collaborator Author

Will work on the CloudFormation tests later.

@kgutwin
Copy link

kgutwin commented Mar 28, 2019

The fix in yaml/pyyaml#266 should be useful for fixing the CloudFormation tests.

Fixing broken tests getmoto#2126
921b5a3 
- KMS
- S3
- CloudFormation (Thanks kgutwin!)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.908% when pulling 921b5a3 on mikegrima:testfixes into 64152f4 on spulec:master.

@mikegrima mikegrima changed the title [WIP] Fixing broken tests #2126 Fixing broken tests #2126 Mar 28, 2019
@mikegrima mikegrima merged commit 78d7d67 into getmoto:master Mar 28, 2019
@mikegrima mikegrima deleted the testfixes branch March 28, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikegrima @kgutwin @coveralls