Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent overlapping expr name prefixes from corrupting projection expr #2412

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Prevent overlapping expr name prefixes from corrupting projection expr #2412

merged 1 commit into from
Sep 12, 2019

Conversation

joolean
Copy link
Contributor

@joolean joolean commented Sep 9, 2019

This patch handles the case when ProjectionExpression looks like "#1, ..., #10" - the previous code used replace, which would make the resulting projection into "foo, ..., foo0".

@joolean
Prevent overlapping expr name prefixes from corrupting projection expr
f4df7a4 
h/t @beheh. This patch handles the case when ProjectionExpression looks
like "#1, ..., #10" - the previous code used `replace`, which would make
the resulting projection into "foo, ..., foo0".
@joolean joolean mentioned this pull request Sep 9, 2019
Closed
@coveralls
Copy link

coveralls commented Sep 9, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 93.313% when pulling f4df7a4 on joolean:issues/2189 into 3a5d857 on spulec:master.

@spulec spulec merged commit 7a01b7c into getmoto:master Sep 12, 2019
@spulec
Copy link
Collaborator

spulec commented Sep 12, 2019

Thank you!

@joolean joolean deleted the issues/2189 branch September 12, 2019 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joolean @coveralls @spulec