Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for moto not unmocking #2578

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Fix for moto not unmocking #2578

merged 1 commit into from
Nov 20, 2019

Conversation

mikegrima
Copy link
Collaborator

@mikegrima mikegrima commented Nov 18, 2019 •
edited
Loading

@mikegrima mikegrima mentioned this pull request Nov 18, 2019
Closed
@mikegrima
Copy link
Collaborator Author

@spulec Would like you to take a look when you get a chance.

@mikegrima mikegrima mentioned this pull request Nov 18, 2019
Closed
@mikegrima mikegrima changed the title Fix for moto not unmocking. [WIP] Fix for moto not unmocking. Nov 18, 2019
@mikegrima mikegrima force-pushed the fixunmock branch 2 times, most recently from bc08f48 to ae556b5 Compare November 18, 2019 19:22
@coveralls
Copy link

coveralls commented Nov 18, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 93.807% when pulling bd777ca on mikegrima:fixunmock into 9ccc9ef on spulec:master.

@mikegrima
Copy link
Collaborator Author

Unit tests all work locally but keep failing on Travis CI. I'm going to need to spend more time on this, unfortunately :(

@mikegrima mikegrima force-pushed the fixunmock branch 2 times, most recently from 9d4abb5 to f438779 Compare November 18, 2019 22:59
Fix for moto not unmocking.
bd777ca 
- Fixes getmoto#2575
- Also upgraded Travis CI to make use of Bionic instead of Xenial
- This may also address concerns raised in getmoto#1793
@mikegrima mikegrima changed the title [WIP] Fix for moto not unmocking. Fix for moto not unmocking Nov 18, 2019
@mikegrima mikegrima requested a review from spulec November 19, 2019 01:20
@bblommers
Copy link
Collaborator

Does this mean the region_name-parameter is now always required when using moto?
That would be quite invasive - I know I always rely on the environmentally configured region, instead of putting it in code

@mikegrima
Copy link
Collaborator Author

mikegrima commented Nov 19, 2019 via email •
edited
Loading

spulec
spulec approved these changes Nov 19, 2019
View reviewed changes
Copy link
Collaborator

@spulec spulec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on this!

@bblommers
Copy link
Collaborator 

Can you confirm if that still works (using the environment variables)?

Confirmed @mikegrima - I've pulled your branch, and tests using boto3.client('dynamodb') (no region specified) still pass

@mikegrima mikegrima merged commit 2af4e7a into getmoto:master Nov 20, 2019
@mikegrima mikegrima deleted the fixunmock branch November 20, 2019 18:06
@mikegrima
Copy link
Collaborator Author

@spulec I'm pretty sure this fixes the issues in #1793 and if so, this would be worthy of a new full release.

@mikegrima
Copy link
Collaborator Author

It looks like the IoT stuff is broken for reasons. I don't have time today to debug, unfortunately.

@spulec spulec mentioned this pull request Nov 21, 2019
Closed
@spulec
Copy link
Collaborator

spulec commented Nov 21, 2019

@mikegrima fixed the IoT stuff with #2585 (it was a new version of botocore that caused the issue).

Going to do a bit more cleanup and maybe merge a couple PRs and then will get a release out.

@xinxinw1 xinxinw1 mentioned this pull request Jan 18, 2021
Closed
@bblommers bblommers mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spulec spulec spulec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can not stop mocking after moto==1.3.14
4 participants
@mikegrima @coveralls @bblommers @spulec