Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing DynamoDB begins_with expression #2583

Merged
merged 5 commits into from
Dec 13, 2019

Conversation

shmygol
Copy link
Contributor

@shmygol shmygol commented Nov 21, 2019

A query fails if it has a space between begins_with and (,
for example: begins_with (#1, :1)

Fix #1996

A query fails if it has a space between `begins_with` and `(`,
for example: ```begins_with (getmoto#1, :1)```

Fix getmoto#1996
@coveralls
Copy link

coveralls commented Nov 21, 2019

Coverage Status

Coverage decreased (-0.01%) to 94.15% when pulling 704a121 on trilliput:issue/1996 into 4d5bf1c on spulec:master.

@shmygol
Copy link
Contributor Author

shmygol commented Nov 21, 2019

Oh, come on!

@shmygol
Copy link
Contributor Author

shmygol commented Dec 12, 2019

Now it's ready to merge!

Copy link
Collaborator

@mikegrima mikegrima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikegrima mikegrima merged commit 9f73a67 into getmoto:master Dec 13, 2019
@elzilrac
Copy link

Thank you for fixing this!!

@nickwilmes
Copy link

Ran into this error just in time to enjoy this fix! Is there a snapshot version I can use until this is in a released version?

@mikegrima
Copy link
Collaborator

Try the latest snapshot on PyPI.

@nickwilmes
Copy link

That did the trick, thanks again for the fix, made my day!

@shmygol
Copy link
Contributor Author

shmygol commented Mar 8, 2020

Did you release the version with the fix? Last version in PyPi is 1.3.14, which is released in November 2019. @mikegrima ?

@bblommers
Copy link
Collaborator

bblommers commented Mar 9, 2020

Hi @trilliput, this fix is included in the latest dev-release: https://pypi.org/project/moto/#history

@shmygol
Copy link
Contributor Author

shmygol commented Mar 9, 2020

@bblommers Oh, I see now. Thanks!

@shmygol shmygol deleted the issue/1996 branch March 9, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pynamodb startswith works with moto but not under pytest
6 participants