Fix DynamoDb2 ExpressionAttributeNames can start with a number #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using pynamodb's support for transactions it makes use of of ExpressionAttributeNames that look like #0 getmoto#1 etc. According to https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Expressions.ExpressionAttributeNames.html And when testing against dynamodb-local these work without issue, however, when testing with moto they fail.
bblommers
approved these changes
Jul 31, 2020
|
The underscore is probably another bug - will merge this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using pynamodb's support for transactions it makes use of of
ExpressionAttributeNamesthat look like#0#1etc. According to the ExpressionAttributeName documentation and when testing against dynamodb-local these names work. However, when testing with moto they fail.This PR modifies the regex for an expression attribute to allow for names that start with a number. This fix allows for tests in my codebase to pass.
As an aside - when reading the documentation it specifies that
ExpressionAttributeNamesmust be alphanumeric, however, looking at the regex and moto tests_appears to be used. Possibly I'm slightly confused or this regex is used in multiple places??