Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Glue] Implement batch_get_jobs #6241

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Conversation

szemek
Copy link
Contributor

@szemek szemek commented Apr 20, 2023

Hello,
while working with moto I got NotImplementedError: The batch_get_jobs action has not been implemented.
If you have any suggestions how to improve my code - please let me know!

cc @bblommers

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #6241 (97e3f8a) into master (28f3f84) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6241   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files         787      787           
  Lines       76454    76465   +11     
=======================================
+ Hits        73641    73652   +11     
  Misses       2813     2813           
Flag Coverage Δ
servertests 36.98% <9.09%> (-0.01%) ⬇️
unittests 96.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/glue/models.py 97.33% <100.00%> (+0.02%) ⬆️
moto/glue/responses.py 99.40% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this feature @szemek

@bblommers bblommers added this to the 4.1.8 milestone Apr 21, 2023
@bblommers bblommers merged commit c6b0486 into getmoto:master Apr 21, 2023
@szemek szemek deleted the glue-batch-get-jobs branch April 21, 2023 12:34
@github-actions
Copy link
Contributor

This is now part of moto >= 4.1.8.dev30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants