Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: add a checksum to a copied object if requested so #6245

Merged

Conversation

rafcio19
Copy link
Contributor

@rafcio19 rafcio19 commented Apr 22, 2023

Resolves #6234

@rafcio19 rafcio19 marked this pull request as ready for review April 22, 2023 15:09
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #6245 (c8f8045) into master (c2e3d90) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6245   +/-   ##
=======================================
  Coverage   96.31%   96.32%           
=======================================
  Files         787      787           
  Lines       76452    76460    +8     
=======================================
+ Hits        73638    73649   +11     
+ Misses       2814     2811    -3     
Flag Coverage Δ
servertests 36.99% <0.00%> (+<0.01%) ⬆️
unittests 96.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/s3/responses.py 95.65% <100.00%> (+0.01%) ⬆️

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - thanks @rafcio19!

@bblommers bblommers changed the title fix: add a checksum to a copied object if requested so S3: add a checksum to a copied object if requested so Apr 22, 2023
@bblommers bblommers added this to the 4.1.8 milestone Apr 22, 2023
@bblommers bblommers merged commit 7fad082 into getmoto:master Apr 22, 2023
@github-actions
Copy link
Contributor

This is now part of moto >= 4.1.8.dev34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checksum generation not implemented when copying files in S3
2 participants