Admin: Enable some tests to run against AWS #6855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only enabled for (2) S3 tests, just to verify the point.
Tests should be marked with two decorators:
The
s3_aws_verified-decorator creates a bucket, and passes the bucket-name to the method.Pytest expects any 'plain' argument to be a fixture, so the bucket-name argument should have a default value to stop pytest from throwing an error:
I'm expecting to extend this to other tests/services at some point. Based on that, there will probably be some refactoring to make this easier to maintain/extend.