Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up openapi-spec-validator version; swith to pytest-order #6943

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

bblommers
Copy link
Collaborator

openapi-spec-validator 0.5.0 was released over a year ago, so it's reasonable to make that the new minimum version IMO. That way we can finally get rid of the ugly ImportError.

This PR also switches our dev-dependencies to use pytest-order (https://github.com/pytest-dev/pytest-order), as that a maintained fork of pytest-ordering.

Closes #6937

@bblommers bblommers added this to the 4.2.7 milestone Oct 23, 2023
@bblommers bblommers added the moto-core PR's that touch the core functionality. This will trigger additional tests. label Oct 23, 2023
@bblommers bblommers force-pushed the admin/change-pytest-order-deps branch from 079f5f3 to 2211450 Compare October 23, 2023 18:19
@bblommers bblommers added moto-core PR's that touch the core functionality. This will trigger additional tests. and removed moto-core PR's that touch the core functionality. This will trigger additional tests. labels Oct 23, 2023
@mweinelt
Copy link
Contributor

mweinelt commented Oct 23, 2023

Note that pytest-order is not a drop-in replacement.

tests/test_core/test_docker.py:11
  /home/runner/work/moto/moto/tests/test_core/test_docker.py:11: PytestUnknownMarkWarning: Unknown pytest.mark.run - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.run(order=0)

tests/test_core/test_docker.py:24
  /home/runner/work/moto/moto/tests/test_core/test_docker.py:24: PytestUnknownMarkWarning: Unknown pytest.mark.run - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.run(order=0)

I think these need to be pytest.mark.order(0).

@bblommers bblommers force-pushed the admin/change-pytest-order-deps branch from 2211450 to 2bf3edb Compare October 23, 2023 19:31
@bblommers
Copy link
Collaborator Author

Good catch @mweinelt!

@bblommers bblommers merged commit 33b1fad into getmoto:master Oct 23, 2023
@bblommers bblommers deleted the admin/change-pytest-order-deps branch October 23, 2023 21:42
@github-actions
Copy link
Contributor

This is now part of moto >= 4.2.7.dev23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moto-core PR's that touch the core functionality. This will trigger additional tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace pytest-ordering with pytest-order
2 participants