Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIGateway: Use new OpenAPISpecValidator API #6951

Merged

Conversation

bblommers
Copy link
Collaborator

As of 0.7.x, openapi_spec_validator recommends using the validate-method.

The old validate-spec method still exists, but throws a warning.

This also refactors one of the new S3 tests a bit to ensure we can run this against AWS.

@bblommers bblommers added this to the 4.2.7 milestone Oct 24, 2023
@bblommers bblommers added the moto-core PR's that touch the core functionality. This will trigger additional tests. label Oct 24, 2023
@bblommers bblommers force-pushed the admin/upgrade-openapi-spec-validator branch from daad621 to e2b19f4 Compare October 24, 2023 21:38
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #6951 (e2b19f4) into master (abe78a8) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6951   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files         830      830           
  Lines       81325    81341   +16     
=======================================
+ Hits        77939    77955   +16     
  Misses       3386     3386           
Flag Coverage Δ
servertests 36.65% <66.66%> (+0.03%) ⬆️
unittests 95.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
moto/apigateway/models.py 95.52% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

@bblommers bblommers merged commit 51672fb into getmoto:master Oct 24, 2023
@bblommers bblommers deleted the admin/upgrade-openapi-spec-validator branch October 24, 2023 22:48
toshyak pushed a commit to toshyak/moto that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moto-core PR's that touch the core functionality. This will trigger additional tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant