-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3: Sending notification to EventBridge OBJECT_CREATED_COMPLETE_MULTIPART_UPLOAD_EVENT
#7435
S3: Sending notification to EventBridge OBJECT_CREATED_COMPLETE_MULTIPART_UPLOAD_EVENT
#7435
Conversation
e1c53fe
to
48ec93d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tsugumi-sys!
The current implementation tries to send two notifications - one for CompleteMultiupload, and one for PutObject.
I've pushed a change to the complete_multipart
-method so that all the logic is in one place - if you could pull in the latest changes from master, you'll see that it will make controlling the notifications a bit easier.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7435 +/- ##
==========================================
- Coverage 95.88% 95.80% -0.08%
==========================================
Files 843 849 +6
Lines 82578 83692 +1114
==========================================
+ Hits 79178 80181 +1003
- Misses 3400 3511 +111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you @tsugumi-sys!
This is now part of moto >= 5.0.3.dev55 |
related #7363