Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: list_object_versions() - Default value for MaxKeys can now be configured #7721

Merged

Conversation

bblommers
Copy link
Collaborator

Fixes #7707

@bblommers bblommers added this to the 5.0.9 milestone May 27, 2024
@bblommers bblommers force-pushed the s3-list-objects-default-max-keys branch from e6c1fa0 to 0bb5a92 Compare May 27, 2024 21:50
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.33%. Comparing base (4501f37) to head (0bb5a92).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7721      +/-   ##
==========================================
- Coverage   94.33%   94.33%   -0.01%     
==========================================
  Files        1092     1092              
  Lines       93037    93039       +2     
==========================================
+ Hits        87769    87770       +1     
- Misses       5268     5269       +1     
Flag Coverage Δ
servertests 29.53% <60.00%> (+<0.01%) ⬆️
unittests 94.30% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit 3300d99 into getmoto:master May 28, 2024
40 checks passed
@bblommers bblommers deleted the s3-list-objects-default-max-keys branch May 28, 2024 17:37
Copy link
Contributor

This is now part of moto >= 5.0.9.dev2

jfmainville pushed a commit to jfmainville/moto that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3: Configure the MaxKeys limit (list_objects/list_objects_v2) using an env variable
1 participant