Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle button doesn't work as expected #1868

Closed
lakshyagupta21 opened this issue Feb 15, 2018 · 7 comments
Closed

Toggle button doesn't work as expected #1868

lakshyagupta21 opened this issue Feb 15, 2018 · 7 comments
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =)

Comments

@lakshyagupta21
Copy link
Contributor

Software and hardware versions

Collect v1.12.2 and older versions

Problem description

Toggle button doesn't work as expected to be while doing search for instances and forms

Steps to reproduce the problem

  1. Delete Saved Form
  2. Search for blank form
  3. Select any form
  4. Close Search
  5. List will be displayed with the selected items but with "Clear all" label

Expected behavior

Instead of "Clear all" button "Select all" should be displayed

Other information

ezgif com-video-to-gif 1

Activities that needs to be taken care for this issue - Delete Saved Form, Send Selected Form

@vladalexgit
Copy link
Contributor

@opendatakit-bot claim

@getodk-bot
Copy link
Member

Hello @vladalexgit!

You have attempted to claim an issue without the labels "quick win", "contributor friendly". It seems like you are new to Open Data Kit, so we suggest working on a quick win issue first. After doing one quick win, then try a contributor friendly issue. We also recommend reading README.md and CONTRIBUTING.md before getting started.

To claim this issue anyway, comment on this issue again with the command @opendatakit-bot claim --force.

@vladalexgit
Copy link
Contributor

@opendatakit-bot claim --force

@getodk-bot
Copy link
Member

Welcome to Open Data Kit, @vladalexgit! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

  • Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
  • Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
  • Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

vladalexgit added a commit to vladalexgit/collect that referenced this issue Feb 15, 2018
The button needs to update its label every time the list content changes
vladalexgit added a commit to vladalexgit/collect that referenced this issue Feb 15, 2018
The button needs to update its label every time the list content changes
vladalexgit added a commit to vladalexgit/collect that referenced this issue Feb 15, 2018
The button needs to update its label every time the list content changes
@shobhitagarwal1612 shobhitagarwal1612 added the good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) label Feb 15, 2018
@anipmehta
Copy link

@opendatakit-bot claim --force

@getodk-bot
Copy link
Member

Welcome to Open Data Kit, @anipmehta! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

  • Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
  • Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
  • Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

@harsh-2711
Copy link

I wanna work on this issue if it's still open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =)
Projects
None yet
Development

No branches or pull requests

6 participants