-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNITest doesn't work #611
Comments
@grzesiek2010 looks like https://sni.velox.ch is down. So that's probably the reason why the test is failing? |
Yes, that would do it. Remove it. I never liked the fact that the test required an external server anyway. I think we're out of the woods on it for the time being. We can always resurrect the test from git history if/when we need it... or... we can try to setup a local SNI-enabled http server as part of the test. Given the nature of the problem and the fix, I am not sure if that's worth the trouble. Or... I could be horribly wrong. |
...and actually, now that I think of it, we're probably better off trying to get out of the business of maintaining our own HTTP client anyway. With the bump in the min API level, things might get simpler towards that end. |
I'm with @batkinson on not using custom http implementation. No need to create more stuff to maintain on our end. |
👏👏 Who wants to file the issue to use a standard HTTP client?!? That would be a huge win if we can now do it. |
Just a reminder - the hurdle is getting the "standard framework" to
implement DigestAuth.
Reverting to the now-deprecated built-in Apache HTTPClient is not a
solution.
…On Wed, Mar 15, 2017 at 1:28 PM, Hélène Martin ***@***.***> wrote:
👏👏 Who wants to file the issue to use a standard HTTP client?!? That
would be a huge win if we can now do it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#611 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACLO0z8Zf7eBrCqTcwSvxShsocHFpmM4ks5rmEn-gaJpZM4MduT5>
.
--
Mitch Sundt
Software Engineer
University of Washington
[email protected]
|
It's silenced for now. We can remove it altogether once we've decided what to do with the httpclient implementation. |
Problem description
SNITest doesn't work.
As I remember everything worked well last month (but I'm not sure).
The text was updated successfully, but these errors were encountered: