Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNITest doesn't work #611

Closed
grzesiek2010 opened this issue Mar 15, 2017 · 7 comments
Closed

SNITest doesn't work #611

grzesiek2010 opened this issue Mar 15, 2017 · 7 comments

Comments

@grzesiek2010
Copy link
Member

Problem description

SNITest doesn't work.

As I remember everything worked well last month (but I'm not sure).

@nribeka
Copy link
Contributor

nribeka commented Mar 15, 2017

@grzesiek2010 looks like https://sni.velox.ch is down. So that's probably the reason why the test is failing?

@batkinson
Copy link
Contributor

Yes, that would do it. Remove it. I never liked the fact that the test required an external server anyway. I think we're out of the woods on it for the time being. We can always resurrect the test from git history if/when we need it... or... we can try to setup a local SNI-enabled http server as part of the test. Given the nature of the problem and the fix, I am not sure if that's worth the trouble. Or... I could be horribly wrong.

@batkinson
Copy link
Contributor

...and actually, now that I think of it, we're probably better off trying to get out of the business of maintaining our own HTTP client anyway. With the bump in the min API level, things might get simpler towards that end.

@nribeka
Copy link
Contributor

nribeka commented Mar 15, 2017

I'm with @batkinson on not using custom http implementation. No need to create more stuff to maintain on our end.

@lognaturel
Copy link
Member

👏👏 Who wants to file the issue to use a standard HTTP client?!? That would be a huge win if we can now do it.

@mitchellsundt
Copy link
Contributor

mitchellsundt commented Mar 16, 2017 via email

@lognaturel
Copy link
Member

It's silenced for now. We can remove it altogether once we've decided what to do with the httpclient implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants