Message won't be disappeared after canceling and refreshing connection to the server #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with success! Verified on Android 4.1, 4.2, 4.4, 5.1, 6.0, 7.0, 8.1 @opendatakit-bot label "behavior verified" |
lognaturel
approved these changes
Jun 5, 2018
|
😊Thank you, @huangyz0918! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2243
What has been done to verify that this works as intended?
I have tested it in my Nexus 6P (Android 8.1).
Why is this the best possible solution? Were any other approaches considered?
The reason for this bug is that we forget to update the
formIdsToDetails(HashMap to keep the form details) after callingupdateAdapter(), so I just added this missed step and it worked. It's the best solution.Are there any risks to merging this code? If so, what are they?
No.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew pmd checkstyle lint findbugsand confirmed all checks still pass.