Use same click effect in reset dialog as used in other settings #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
changed the title
lognaturel
changed the title
lognaturel
approved these changes
Jul 10, 2018
|
Tested with success! @opendatakit-bot unlabel "needs testing" |
|
@grzesiek2010 Just a thought! If the style of each checkbox is the same, it seems more convenient to use a custom style here and use that instead of copying & pasting the styles for each. This also makes future changes easier |
lognaturel
approved these changes
Jul 11, 2018
|
I agree, @shobhitagarwal1612! 👍 Since this does fix a current problem and has been reviewed by @kkrawczyk123, let's merge now and the style can be added in a follow-on PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2036
What has been done to verify that this works as intended?
I tested the
Reset Settingsdialog.Why is this the best possible solution? Were any other approaches considered?
Because now we use the same effect for checkboxes like in other settings.
Are there any risks to merging this code? If so, what are they?
No.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew pmd checkstyle lintDebug spotbugsDebugand confirmed all checks still pass.