Support implicit intents using any kind of uri #2386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2385
What has been done to verify that this works as intended?
Used the form in the issue (https://github.com/opendatakit/collect/files/2207874/dial-number.xml.txt) as well as the one from #2351.
Why is this the best possible solution? Were any other approaches considered?
I once again considered changing
populateParameters
to a method that returns a map of resolved parameters. I decided against it because the method is also used inODKView
to handle external apps that populate field lists. Instead, I extracted the functionality to resolve a value so it could be used just on theuri_data
value.Are there any risks to merging this code? If so, what are they?
This does affect any parameter passed into an external app so it would be good to do a quick regression check with something like https://github.com/opendatakit/counter.
Do we need any specific form for testing your changes? If so, please attach one.
https://github.com/opendatakit/collect/files/2207874/dial-number.xml.txt
Does this change require updates to documentation? If so, please file an issue here and include the link below.
getodk/docs#775
Before submitting this PR, please make sure you have:
./gradlew pmd checkstyle lintDebug spotbugsDebug
and confirmed all checks still pass.