Added Material Design Icons open source licenses #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-alexander
commented
Jul 20, 2018
| @@ -23,6 +23,7 @@ | |||
| padding: 1em; | |||
| white-space: pre-wrap; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I didn't add this empty line! Android Studio did after formatting 😅
lognaturel
approved these changes
Jul 20, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the licenses required to use the Material Design Icons from https://materialdesignicons.com
What has been done to verify that this works as intended?
I went to the
Aboutscreen and verified that the license was being displayed correctly.Why is this the best possible solution? Were any other approaches considered?
Yes.
Are there any risks to merging this code? If so, what are they?
No.
Do we need any specific form for testing your changes? If so, please attach one.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
./gradlew pmd checkstyle lintDebug spotbugsDebugand confirmed all checks still pass.