Keyboard appears and full submission name is not visible if submission name is not editable #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
changed the title
|
Tested with success @opendatakit-bot unlabel "needs testing" |
|
@kkrawczyk123 What happens if there is a very very very long name with no newlines? |
|
@yanokwa it is wrapped like: |
yanokwa
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2819
What has been done to verify that this works as intended?
I've tested rotating a device on the
end of formscreen and the form attached to the issue.Why is this the best possible solution? Were any other approaches considered?
The first commit is just a simple fix, the second one contains a fix that enables multiple lines to display an entire text.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This pr brings two changes:
It should be safe and I can't see any big risk here or other cases that we should test.
Do we need any specific form for testing your changes? If so, please attach one.
One form is attached to the issue, apart from that we can use any form.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.