Display progress bar only form forms that are being sent via SMS

[grzesiek2010]

What has been done to verify that this works as intended?

I tested the form list.

Why is this the best possible solution? Were any other approaches considered?

This pr #2825 introduced new icons for each form state. Those icons indicate if a form has been sent, so now we need the progress bar for forms that are being sent via SMS.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This pr just removes the redundant progress bar. It's not risky and testing the form list (just it's layout) would be enough.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[cooperka]

@grzesiek2010 I think the progress bar is still relevant, it's used when submitting via SMS. The "message" icon appears when sending but the progress bar indicates the progress (e.g. if the form needs to be sent in 5 different messages, it will progress while sending).

We could selectively show the progress bar only for those users with SMS enabled, what do you think? As of #2892 this would be nobody, but we're planning to add it back so maybe just add a feature flag?

[grzesiek2010]

@cooperka I doubt that they accept our app and allow us to send SMS automatically but ok. I edited the approach and kept the progress bar which now is visible only for forms that are being sent via SMS to show the progress. Of course, testing is not possible because we disable the SMS feature.

[cooperka]

@opendatakit-bot label "needs testing"

[cooperka]

LGTM

[mmarciniak90]

Tested with success

Tested on Android 4.2, 4.4, 5.1, 6.0, 7.0, 8.1
Tested cases:

• all form status
• light/dark theme
• rotating, screen locking

I was not able to check that this bar is visible when the form is sent via SMS.

@opendatakit-bot unlabel "needs testing"
@opendatakit-bot label "behavior verified"