Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our themes to fix the default tintMode to SRC_IN. #2902

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Use our themes to fix the default tintMode to SRC_IN. #2902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions collect_app/src/main/res/values/theme.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@
<item name="android:textDirection" tools:targetApi="17">locale</item>
<item name="warningColor">@color/red_500</item>
<item name="dividerCompat">@android:drawable/divider_horizontal_dark</item>
<!--
The default tint mode for ImageViews is SRC_ATOP, which produces
incorrect blending results when tinting images with a colour that
has an alpha channel (for example, the alpha channel is used to
turn disabled buttons grey). The correct tint mode is SRC_IN,
which is the default tint mode in Android everywhere else. See:
https://developer.android.com/reference/android/widget/ImageView.html#attr_android:tint
-->
<item name="android:tintMode" tools:targetApi="21">src_in</item>
</style>

<style name="AppTheme.SettingsTheme.Dark" parent="BaseDarkAppTheme">
Expand Down Expand Up @@ -69,6 +78,7 @@
<item name="android:textDirection" tools:targetApi="17">locale</item>
<item name="warningColor">@color/red_500</item>
<item name="dividerCompat">@android:drawable/divider_horizontal_bright</item>
<item name="android:tintMode" tools:targetApi="21">src_in</item>
</style>

<style name="AlertDialogTheme.Light" parent="Theme.AppCompat.Light.Dialog.Alert">
Expand Down