Shorten sheet title if it's too long #2919
Merged
+31
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
COLLECT-2918
branch
from
8944066 to
1a527f0
Compare
cooperka
suggested changes
Feb 27, 2019
collect_app/src/main/java/org/odk/collect/android/upload/InstanceGoogleSheetsUploader.java
Outdated
Show resolved
Hide resolved
grzesiek2010
force-pushed
the
COLLECT-2918
branch
2 times, most recently
from
35ea46c to
09fb48c
Compare
grzesiek2010
force-pushed
the
COLLECT-2918
branch
from
09fb48c to
d39b63d
Compare
|
@cooperka I improved the solution you can take a look. |
|
@opendatakit-bot label "needs testing" |
|
Tested with success Verified on Android: 4.2, 4.4, 5.1, 6.0, 7.0, 8.1 @opendatakit-bot unlabel "needs testing" |
shobhitagarwal1612
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2918
What has been done to verify that this works as intended?
I tested the form attached to the issue.
Why is this the best possible solution? Were any other approaches considered?
Google just doesn't allow to create sheets with longer names so we need that fix to be able to send data, there is no other solution.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It's not very risky but sending forms to GS should be tested to confirm the problem is solved and there is no regression.
Do we need any specific form for testing your changes? If so, please attach one.
The form attached to the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.