Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed attempt to re-open an already-closed object #2926

Merged
merged 2 commits into from
Mar 6, 2019

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Feb 28, 2019

Closes #2583

What has been done to verify that this works as intended?

I tested the fix with the steps I described in the issue.

Why is this the best possible solution? Were any other approaches considered?

The issue is fixed in the first commit. The second one is just a code improvement. We use LoaderManager so startManagingCursor(c); was redundant and caused the crash.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It should just fix the issue. Nothing else should be changed.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 changed the title Collect 2583 1 Fixed attempt to re-open an already-closed object Feb 28, 2019
@yanokwa yanokwa added this to the v1.21 milestone Mar 4, 2019
@mmarciniak90
Copy link
Contributor

Tested with success!

Verified on Android: 4.2, 4.4, 5.1, 6.0, 7.0, 8.1
Verified cases:

Use case 1:

  1. User fills form
  2. User sends this form with success
  3. User goes to Delete Saved Form view and deletes this instance
  4. User goes to View Sent Form
  5. User sees that this instance is no longer available, it is greyed out
  6. User clicks on this instance and changes device orientation
  7. Collect does not crash

Use case 2:

  1. Delete after send option in Form management settings is selected
  2. User fills form
  3. User sends this form with success
  4. User goes to View Sent Form
  5. User sees that this instance is no longer available, it is greyed out
  6. User clicks on this instance and changes device orientation
  7. Collect does not crash

@opendatakit-bot unlabel "needs testing"
@opendatakit-bot label "behavior verified"

@grzesiek2010 grzesiek2010 removed the request for review from cooperka March 6, 2019 12:52
@grzesiek2010 grzesiek2010 merged commit c8cc391 into getodk:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attempt to re-open an already-closed object
5 participants