Fixed enabled but grayed out rows #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shobhitagarwal1612
approved these changes
Mar 23, 2019
|
Tested with success Verified on Android: 4.2, 4.4, 5.1, 6.0, 7.0, 8.1 Verified cases:
@opendatakit-bot unlabel "needs testing" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2956
What has been done to verify that this works as intended?
I tested the list of sent forms.
Why is this the best possible solution? Were any other approaches considered?
The issue takes place because rows in
ListVieware reused that means if we have a few disabled rows (with grayed out elements) the same element might be reused for another element which is enabled. That's why we need to set alpha every time. The list of sent forms is the one that might be really big I guess in contrast to the list of blank/filled forms, so it could work slowly. This solution fixes the problem but in the feature, we should use RecyclerView instead (I'll file an issue).How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Implemented changes are only related to the list of sent forms so testing that list would be enough. It's not risky.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.