Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for v1.21 beta #2969

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Update for v1.21 beta #2969

merged 1 commit into from
Mar 27, 2019

Conversation

yanokwa
Copy link
Member

@yanokwa yanokwa commented Mar 27, 2019

Closes #

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Do we need any specific form for testing your changes? If so, please attach one.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@yanokwa yanokwa requested a review from lognaturel March 27, 2019 20:06
@lognaturel lognaturel merged commit 91af293 into getodk:master Mar 27, 2019
@grzesiek2010 grzesiek2010 added this to the v1.21 milestone Apr 2, 2019
@yanokwa yanokwa deleted the update-languages branch April 24, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants