Prevent NullPointerExceptions when the activity is null #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, during an orientation change.
zestyping
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Okay, I was able to take a moment to examine how this crash happened. getActivity() returns null when a Fragment has yet to be attached. So if the GoogleMapFragment is constructed and a location update arrives in the tiny period between construction and being attached to the activity, the activity can be null during updateLocationIndicator().
So I fully agree with your assessment that the null check in onLocationReady resolves the crash in #2979, and the null check in createMarker is probably not necessary but doesn't hurt.
grzesiek2010
approved these changes
Apr 2, 2019
|
Tested with success Verified on Android: 4.2, 4.4, 5.1, 6.0, 7.0, 8.1 Verified cases:
@opendatakit-bot unlabel "needs testing" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2979
What has been done to verify that this works as intended?
I rotated the screen quickly on first launch of a geo widget using Google Maps and kept doing it over and over again. I believe the issue could occur not just when first launching the question but whenever a location update was received at the same time as an orientation change. It's just easiest to reproduce on first launch.
Why is this the best possible solution? Were any other approaches considered?
I considered doing the check on
getActivity()being null deeper in the code but this ended up making the most sense to me: only update the location indicator if the activity exists. The other null check increateMarkeris probably not strictly necessary but I couldn't quickly convince myself that the activity could never be null there so I figured it's better to be defensive.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It only fixes the bug. If the activity is null, users can't see anything anyway so this won't affect them.
Do we need any specific form for testing your changes? If so, please attach one.
Any form with geo widgets.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.