Fixed styling in select_one/select_multiple widgets with minimal appearance #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er the button as well
lognaturel
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
It seems that in an ideal world there would be an abstraction one step before widgets that ensures this consistent behavior for all selects. But that can be an exercise for another day.
It's likely some users will have been relying on unstyled choices with the minimal appearance but there's not a whole lot we can do about that.
|
Tested with success Verified on Android: 4.2, 4.4, 5.1, 6.0, 7.0, 8.1 Verified cases:
Below screenshots from v1.22.4 on the left and fix on the right
@opendatakit-bot unlabel "needs testing" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3190
What has been done to verify that this works as intended?
I tested the attached for which contains sample for both select_one/select_multiple widgets with minimal appearance.
Why is this the best possible solution? Were any other approaches considered?
It's just a fix for those two widgets. There is no other solution.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The implemented changes are related only to those two widgets (SpinnerWidget and SpinnerMultiplWidget) so testing the attached form should be ok there is no need to test other widgets or other functionalities.
Do we need any specific form for testing your changes? If so, please attach one.
style-example.xml.txt
style-example.xlsx
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.