Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For vector mbtiles, draw only lines (no fills). #3238

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

zestyping
Copy link
Contributor

Scope: MapboxMapFragment
Requested reviewers: @lognaturel

Example of the default rendering of countries.mbtiles, prior to this change:

mbtiles-fills

Example of the rendering after this change:

mbtiles-lines

@lognaturel
Copy link
Member

lognaturel commented Jul 24, 2019

Closes #3240

@lognaturel lognaturel added this to the v1.23 milestone Jul 25, 2019
@mmarciniak90
Copy link
Contributor

We were able to test this issue only on Androids > 4 because of the crash reported in #3246

Verified on Android: 5.1, 6.0, 7.0

Green areas are no longer visible on the version with the fix.

@opendatakit-bot unlabel "needs testing"
@opendatakit-bot label "behavior verified"

@lognaturel lognaturel merged commit de805c9 into getodk:master Jul 25, 2019
@zestyping
Copy link
Contributor Author

This closes #3240.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants