Fixed GD 403 error #3469
Merged
Fixed GD 403 error #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
approved these changes
Nov 25, 2019
There was a problem hiding this comment.
Soooo frustrating. Thank you @grzesiek2010 for doing that detective work.
|
Nice job, @grzesiek2010! To verify this worked, I used a google-services.json file that has an identical structure to the ones we have in release and debug. I used the values from the Firebase JSON, but pulled the oauth_client.client_id information from what we have in Google Console and have been using in previous releases. I then did the odkCollectRelease build and confirmed the following.
@opendatakit/testers No need to verify this change since I have done that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3468
What has been done to verify that this works as intended?
I tested downloading forms from GD using
odkCollectReleasebuild.Why is this the best possible solution? Were any other approaches considered?
It's a bug in gradle https://issuetracker.google.com/issues/131072620
We updated gradle https://github.com/opendatakit/collect/pull/3423/files#diff-c197962302397baf3a4cc36463dce5eaR9 and it caused the problem.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It just requires testing GD using
odkCollectRelease, that's all.Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.