Fixed google bug 154855417 #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
Jun 1, 2020
collect_app/src/main/java/org/odk/collect/android/application/Collect.java
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/application/Collect.java
Show resolved
Hide resolved
grzesiek2010
force-pushed
the
COLLECT-3884
branch
from
ac8f303 to
3a6b229
Compare
grzesiek2010
force-pushed
the
COLLECT-3884
branch
from
3a6b229 to
0a03f1f
Compare
seadowg
approved these changes
Jun 1, 2020
|
@grzesiek2010 seeing some weird issues on Circle CI. Could you try rerunning "from start" to see if it fixes it? |
it's green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3884
What has been done to verify that this works as intended?
Not much since we can't reproduce it. I just prepared my changes according to https://issuetracker.google.com/issues/154855417#comment509
Why is this the best possible solution? Were any other approaches considered?
I implemented changes according to the explanation provided here (as I said above): https://issuetracker.google.com/issues/154855417#comment509
I adjusted the sample fix for android keeping just the fix for maps v2 and using our shared preferences.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We are not able to reproduce the issue and also testing doesn't make sense.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.