Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep swiping blocked until AddRepeatDialog is closed #3898

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jun 3, 2020

Closes #3897

What has been done to verify that this works as intended?

I was able to reproduce the issue so I also confirmed the fix works.

Why is this the best possible solution? Were any other approaches considered?

We released swiping to early and it was possible to swipe multiple times in a case when the AddRepeatDialog should appear and block it.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It's a pretty safe and isolated fix so we can just verify the mentioned scenario.

Do we need any specific form for testing your changes? If so, please attach one.

I used:
repeatGr.xlsx

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@mmarciniak90
Copy link
Contributor

Tested with success

Verified on Androids: 6.0, 7.0, 8.1, 9.0

Verified cases:

  • fill a new submission
  • fill a previously saved submission
  • horizontal/vertical device orientation
  • rotation
  • light/dark mode
  • minimization
  • a few other forms with repeat sections

@kkrawczyk123
Copy link
Contributor

@grzesiek2010 I have noticed the same crash when following scenario:

  1. Add group using + button
  2. Swipe fast

I have used the same form that you have attached to pr.
see attached gif:
ezgif com-video-to-gif (4)

@getodk-bot unlabel "needs testing"

@grzesiek2010
Copy link
Member Author

@kkrawczyk123 Nice catch try now.

@kkrawczyk123
Copy link
Contributor

Confirmed that both issues have been fixed now.
Verified on Androids 5.1, 7.1 and 10.

@getodk-bot unlabel "needs testing"
@getodk-bot label "behavior verified"

@grzesiek2010 grzesiek2010 merged commit f96250c into getodk:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A user is able to swipe twice when the second swipe should be blocked by Add new group dialog
5 participants