Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save current screen answers when quitting form #3899

Merged
merged 3 commits into from
Jun 3, 2020

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jun 3, 2020

This was the reason the Track Changes Reason tests were failing.

What has been done to verify that this works as intended?

Added new tests to make a bug in this area a little more obvious (hopefully) and ran tests to check we're now green.

Why is this the best possible solution? Were any other approaches considered?

I think really we need to look at moving the screen answer saving out of the FormEntryActivity and into the FormSaveViewModel. I didn't want to get into that to get green again so just used a listener on QuitFormDialogFragment to call the FormEntryActivity's save logic.

I think it's a good step forward to have some Espresso tests covering this flow a little better however.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I think it's best to do a straight merge on this as it is mostly a step backwards and gets us green again.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review June 3, 2020 12:47
Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. Well, it's really good additional test coverage to have, certainly.

@lognaturel lognaturel merged commit b41f4bc into getodk:master Jun 3, 2020
@seadowg seadowg deleted the fix-track-changes branch June 4, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants