Save current screen answers when quitting form #3899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the reason the Track Changes Reason tests were failing.
What has been done to verify that this works as intended?
Added new tests to make a bug in this area a little more obvious (hopefully) and ran tests to check we're now green.
Why is this the best possible solution? Were any other approaches considered?
I think really we need to look at moving the screen answer saving out of the FormEntryActivity and into the FormSaveViewModel. I didn't want to get into that to get green again so just used a listener on QuitFormDialogFragment to call the FormEntryActivity's save logic.
I think it's a good step forward to have some Espresso tests covering this flow a little better however.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I think it's best to do a straight merge on this as it is mostly a step backwards and gets us green again.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.