Revise notification behaviour for Match Exactly #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
changed the title
seadowg
commented
Jul 31, 2020
| @@ -53,40 +52,14 @@ public void whenMatchExactlyEnabled_clickingFillBlankForm_andClickingRefresh_get | |||
| } | |||
|
|
|||
| @Test | |||
| public void whenMatchExactlyEnabled_getsLatestFormsFromServer_automaticallyAndRepeatedly() throws Exception { | |||
There was a problem hiding this comment.
I decided to revise how the tests are written to drive out the new behaviour rather than just adding more. Along with the changed/new unit tests everything was TDD'd out and I'm pretty sure we didn't lose anything.
seadowg
commented
Jul 31, 2020
| @@ -113,7 +113,7 @@ the specific language governing permissions and limitations under the License. | |||
| android:configChanges="orientation|screenSize" | |||
| android:windowSoftInputMode="stateHidden" /> | |||
| <activity android:name=".activities.InstanceChooserList" /> | |||
| <activity android:name=".activities.FillBlankFormActivity" /> | |||
| <activity android:name=".activities.FillBlankFormActivity" android:launchMode="singleTop"/> | |||
There was a problem hiding this comment.
Not a fan of changes here but at least it's driven out by a test in Espresso
lognaturel
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3999.
Blocked by #3992.In addition to the problems described in the issue I also made it so error notifications are cleared/cancelled when a sync succeeds.
What has been done to verify that this works as intended?
New/revised tests and was able to verify manually
Why is this the best possible solution? Were any other approaches considered?
I've left some comments inline.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Good to just check the issue is fixed and that Match Exactly notifications behave as expected.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.