Use Intent.ACTION_GET_CONTENT instead of Intent.ACTION_PICK to pick an image with settings #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n image with settings
|
Tested with success Verified on Android versions: 8.1, 9.0, 10.0 Verified cases:
|
|
Tested with success also on Androids 5.1 and 11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4776
What has been done to verify that this works as intended?
I tested picking images with settings.
Why is this the best possible solution? Were any other approaches considered?
According to the docs https://developer.android.com/reference/android/content/Intent#ACTION_GET_CONTENT we should use
Intent.ACTION_GET_CONTENTinstead ofIntent.ACTION_PICK. I also confirmed that the behavior is better if we useIntent.ACTION_PICK.We also discussed the issue on slack https://getodk.slack.com/archives/C35ENHA64/p1628005284054700
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We should test picking images with settings, not importing just picking.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.