Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MultiClickSafeButton in ProjectSettingsDialog for all the buttons #4815

Merged
merged 8 commits into from
Sep 1, 2021

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Aug 27, 2021

Closes #4811

What has been done to verify that this works as intended?

I tested the fix and confirmed that everything works fine.

Why is this the best possible solution? Were any other approaches considered?

It's the same solution we use across the app. I don't know if it was possible to reproduce the same issue clicking on Add project button but just in case I handled this button as well.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It's a safe fix so we just need to confirm that the issue no longer exist.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 requested a review from seadowg August 27, 2021 08:33
@mmarciniak90
Copy link
Contributor

@grzesiek2010, I'm still able to open e.g. Get Blank Form or Delete Saved Form page when I click a lot of times on Add Project or About.
ezgif com-video-to-gif

@grzesiek2010
Copy link
Member Author

I'm still able to open e.g. Get Blank Form or Delete Saved Form page when I click a lot of times on Add Project or About.

ahh it was a tricky case. Ok now everything should be fine.

@mmarciniak90
Copy link
Contributor

Tested with success

Verified on Android 8.1, 9.0, 10.0

Verified cases:

  • multi-click on Add project
  • multi-click on About
  • vertical device orientation
  • horizontal device orientation
  • RTL language

@kkrawczyk123
Copy link
Contributor

Tested with success also on Androids 5.1 and 11.

@grzesiek2010 grzesiek2010 merged commit 00832d5 into getodk:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple clicks on Add Project/About open up view from Main menu
4 participants