Fixed attaching gifs in ImageWidget #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
approved these changes
Sep 6, 2021
|
Tested with success Verified on Android 8.1, 9.0, 10.0 Verified cases:
|
|
Verified also on Androids 5.1 and 11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4819
What has been done to verify that this works as intended?
I added automated tests and verified the fix manually.
Why is this the best possible solution? Were any other approaches considered?
The issue occurred after upgrading
androidx.exifinterface:exifinterfaceI don't think that point release brought anything that we would need to apply on our side so I guess there must be a bug in that newest release. I downgraded that dependency and we can check it again after next release and then if it still doesn't work we can spend more time on it.Generally the problem is that we set exif attributes no matter what image format is used. Gifs are not supported but it should not cause spoiling those files as well. At least it didn't in the previous release of that dependency. I also didn't want to make to many changes to avoid conflicts with #4664 so yeah it's better to check it again later and for now just fix the problem in the easiest possible way.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It's a safe fix since I just downgraded one dependency to a version that we used before so we just need to focus on the described scenario.
Do we need any specific form for testing your changes? If so, please attach one.
Any form with
ImageWidget.Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.