Fixed visibility of the location crosshair in mapbox #4867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
reviewed
Oct 18, 2021
| @@ -3,7 +3,9 @@ | |||
| android:height="48dp" | |||
| android:viewportWidth="48" | |||
| android:viewportHeight="48"> | |||
|
|
|||
| <!-- Do not use theme attributes to define the color https://github.com/mapbox/mapbox-gl-native-android/issues/716 --> | |||
seadowg
approved these changes
Oct 18, 2021
|
@grzesiek2010 I have noticed that crosshair disappears when changing offline layers, see gif: A similar issue is visible when an offline layer is selected and minimize app. When go back to app crosshair is not visible. Issue does not occur when minimize app when offline layer is not selected. It was hard to find Collect version where crosshair was visible. I tried 1.26 where both cases that I am describing works well. Could you please take a look? |
|
This is a different bug, please report a separate issue for it. |
|
Tested with success! Tested cases:
|
|
Tested with success on Android 8.1, 9.0, 10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4858
What has been done to verify that this works as intended?
I tested the fix manually.
Why is this the best possible solution? Were any other approaches considered?
This seems to be a bug in mapbox which I reported here mapbox/mapbox-gl-native-android#716 so this seems to be the only solution for now.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Please just verify that the issue is fixed. Nothing else should be affected.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.