Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "General Settings" with "unprotected Settings" or just "Settings" #4902

Merged
merged 6 commits into from
Nov 18, 2021

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Nov 8, 2021

Closes #4892

What has been done to verify that this works as intended?

I reviewed implemented changes and ran automated tests.

Why is this the best possible solution? Were any other approaches considered?

I fixed the strings that contained General settings as described in the issue. Additional I went the extra mile and renamed our methods and comments where instead unprotected.protected settings we still had general/admin settings. I could have done even more an rename local variables but I think it would bow the pr too much so I decided to back off.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It doesn't require testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

Copy link
Member

@seadowg seadowg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run through the app quickly as well as the commits. This is good to merge once we unfreeze!

@grzesiek2010 grzesiek2010 merged commit 3743250 into getodk:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "General Settings" with "unprotected Settings" or just "Settings"
2 participants