Ignore choices with invalid geometry in Select one from map widget

[grzesiek2010]

Closes #5368

What has been done to verify that this works as intended?

I've tested the fix manually and added automated tests.

Why is this the best possible solution? Were any other approaches considered?

So far we would throw an error if any of X choices had an invalid geometry. This doesn't make sense such choices should be just excluded not to block users.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Choices with invalid geometries should be ignored when used in Select one from map widget so that users can still see other valid choices. Please test all possible options: external csv attachments (like the one attached below) and geojson attachments.

Do we need any specific form for testing your changes? If so, please attach one.

I used a form with a csv file:
geoTest.xlsx
geo.csv

but please also verify geojson

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[dbemke]

Android version

10, 13

Device used

Redmi 9T, Pixel 6a

Problem description

Leaving a blank space in geometry values for "select place” included in xml file of a form crashes the app.

Steps to reproduce the problem

1. Go to the form with empty geometry value.
   mapinternalselectlocalizedchanged.xml.txt
2. Tap "select place”

Expected behavior

The app shouldn’t crash.

[grzesiek2010]

This happens in javarosa so it's kind of different I would rather leave it as is for now and file a separate issue.

[dbemke]

Tested with Success!

Verified on Androids: 10

Verified cases:

• issue Invalid geometry in CSV file with entities #5368 is no longer reproducing
• forms: Select one from map, S1FromMap, Map internal select localized, Map internal select invalid
• invalid geometry in a geojson file set to: 199.xxx, "a” instead of a number, valid number in brackets, only longitude valid, negative values
• all points in geojson file with invalid geometry
• in CSV file changing geometry values to: valid in brackets, 0.0, 199. xxx, a blank space
• invalid geometry in CSV file with a dataset
• changing geometry in xml file (map internal select localized form- geometry in xml: 199.xx, "a”, a blank space)
• changing geometry in xlsx file (map internal select invalid)
• submissions from different versions of a form with different invalid geometry
• screen rotation, minimizing the app, using backward button

The issue form the PR is filed as a separate issue.

[srujner]

Tested with Success!

Verified on Androids: 13

[seadowg]

Leaving a blank space in geometry values for "select place” included in xml file of a form crashes the app.

@dbemke is this an existing case? i.e. is it present in v2022.4.0?

[dbemke]

@seadowg It's in the PR and v2022.4.0 but I guess we haven't tested that case of invalid geometry in xml file before