Text question type should allow new lines, wrap text, and respect the rows attribute #6271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6270
The problem was that when we started setting input types programmatically (to support the masked appearance) we did that in the wrong way. Instead of adding
InputType.TYPE_TEXT_VARIATION_PASSWORD
if needed to the default input types we removed the default ones always using onlyInputType.TYPE_CLASS_TEXT
orInputType.TYPE_CLASS_TEXT or InputType.TYPE_TEXT_VARIATION_PASSWORD
instead. Because of that, we lostInputType.TYPE_TEXT_FLAG_CAP_SENTENCES
andInputType.TYPE_TEXT_FLAG_MULTI_LINE
that normally are applied by default.Why is this the best possible solution? Were any other approaches considered?
Instead of clearing the default input type and adding
InputType.TYPE_CLASS_TEXT
orInputType.TYPE_TEXT_VARIATION_PASSWORD
we need to mix the existing input type withInputType.TYPE_CLASS_TEXT or InputType.TYPE_TEXT_VARIATION_PASSWORD
.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Please verify that the masked appearance is working well with string widgets and that text fields can expand and have multiple lines (as it was before v2024.2).
Do we need any specific form for testing your changes? If so, please attach one.
I used this one:
maskedANDRows.xlsx
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest