Fixed hiding error in external widgets #6273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
commented
Jul 18, 2024
| @@ -64,6 +66,26 @@ public void widgetShouldBeRegisteredForContextMenu() { | |||
| assertThat(viewsRegisterForContextMenu.get(1).getId(), is(widget.getId())); | |||
| } | |||
|
|
|||
| @Test | |||
| public void errorDisappearsOnSetData() { | |||
There was a problem hiding this comment.
We should have such tests for other question types. Here is a separate issue for that #6274.
seadowg
approved these changes
Jul 19, 2024
|
Tested with Success Verified on devices with Android 10, 14 Verified Cases:
|
seadowg
added a commit
to seadowg/collect
that referenced
this pull request
Jul 24, 2024
Fixed hiding error in external widgets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6266
Why is this the best possible solution? Were any other approaches considered?
It's a bug fix so nothing to discuss here.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This fixes hiding errors in external string widgets. Other widgets should not be affected but we can't be sure maybe we have similar issues with other types of questions as well (it would be good to test them).
Do we need any specific form for testing your changes? If so, please attach one.
The form that is attached to the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest