Functionnal test #288
Merged
Functionnal test #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Yeah, Agreed with you on this point. Pelican shouldn't change its output without us knowing exactly what's going on. Thanks for your work on this! |
|
The tests you introduced are failing on my machine. I don't et exactly why. Can you give me the steps I should reproduce to run the tests like you are? Thanks! |
almet
added a commit
that referenced
this pull request
Apr 1, 2012
This allows everyone to have the same setup when generating the tests. It is useful for #288 for instance.
|
Yes I've noticed that the output was system dependent since it uses the $USER if no author is mentioned in the articles. |
|
Cool, also, it could be nice to add instructions to the "how to contribute" page so contributors could regenerate the output if needed. |
This was referenced Apr 4, 2012
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test that the output of the samples pelican project is correct
I think it is important to be sure that the output remain unchanged.