Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ambiguous option error when two flags are similar to "out". #4

Merged
merged 4 commits into from
Sep 30, 2019

Conversation

anjayajodha
Copy link
Contributor

When using the az mixin with "az iot hub device-identity create" it does not succeed because there are two similar flags "output" and "output-dir".

Adding in the full "output" flag to the command removes this issue.

Example:
ERROR: az iot hub device-identity create: error: ambiguous option: --out could match --output, --output-dir

Fixing ERROR: az iot hub device-identity create: error: ambiguous option: --out could match --output, --output-dir.

By using "output" rather than "out" we can avoid this.
@squillace
Copy link

@carolynvs you wanna have a quick look? Seems simple enough to me..

@carolynvs carolynvs self-assigned this Sep 30, 2019
@carolynvs carolynvs added the bug Oops, sorry! label Sep 30, 2019
@carolynvs
Copy link
Member

Yup! Agreed, we should be using --output by default instead of the shorter --out, fixing that right now.

Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny change to the test then this is ready to merge!

Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! 💯

@carolynvs carolynvs merged commit f006e06 into getporter:master Sep 30, 2019
@carolynvs
Copy link
Member

I just pushed up a new release of the az mixin with your fix. You can install it with

porter mixin install az

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oops, sorry!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants