-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add login
command
#74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
c259af5
to
25cbf5d
Compare
It think it would be beneficial to add some examples to the documentation showing the different ways to login |
1. Check for the existence of `~/.azure`, which signals we're already logged in using some means. 2. Check the environment for a service principal as defined by the environment variables `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_CLIENT_SECRET`. 3. Check the `AZURE_CLIENT_ID` environment variable for the client ID of a user-assigned managed identity. 4. Use the system-assigned managed identity for the Azure resource if it's enabled. Signed-off-by: Leo Bergnéhr <[email protected]>
Signed-off-by: Leo Bergnéhr <[email protected]>
Signed-off-by: Leo Bergnéhr <[email protected]>
Signed-off-by: Leo Bergnéhr <[email protected]>
- Refactor some common code into method. - Use `true` as a no-op command when using an existin .azure directory. - Fix indentation. Signed-off-by: Leo Bergnéhr <[email protected]>
Signed-off-by: Leo Bergnéhr <[email protected]>
Signed-off-by: Leo Bergnéhr <[email protected]>
kichristensen
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33.
~/.azure
, which signals we're alreadylogged in using some means.
environment variables
AZURE_CLIENT_ID
,AZURE_TENANT_ID
, andAZURE_CLIENT_SECRET
.AZURE_CLIENT_ID
environment variable for the client ID ofa user-assigned managed identity.
it's enabled.
.azure
directory.