Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #162

Merged
merged 1 commit into from
Sep 8, 2022
Merged

update dependencies #162

merged 1 commit into from
Sep 8, 2022

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Aug 29, 2022

  • update k8s dependencies
  • update porter to v1.0.0-rc.1
  • update getporter/magefile to v0.3.2
  • remove Debug flag since it's not used
  • update build pipeline to use go 1.18

@VinozzZ
Copy link
Contributor Author

VinozzZ commented Aug 29, 2022

go: downloading get.porter.sh/operator v0.6.0
go: downloading github.com/onsi/gomega v1.20.1
go: downloading github.com/hashicorp/go-hclog v1.2.2
go: downloading github.com/cnabio/cnab-go v0.24.0
go: downloading github.com/onsi/ginkgo/v2 v2.1.4
go: downloading github.com/cespare/xxhash v1.1.0
get.porter.sh/plugin/kubernetes/pkg/kubernetes imports
	get.porter.sh/porter/pkg/plugins imports
	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc tested by
	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.test imports
	google.golang.org/grpc/interop imports
	golang.org/x/oauth2/google imports
	cloud.google.com/go/compute/metadata: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:
	cloud.google.com/go v0.97.0 (/home/yingrong/go/pkg/mod/cloud.google.com/[email protected]/compute/metadata)
	cloud.google.com/go/compute v1.7.0 (/home/yingrong/go/pkg/mod/cloud.google.com/go/[email protected]/metadata)

@VinozzZ VinozzZ force-pushed the bump-deps branch 5 times, most recently from f618ccd to b269f21 Compare September 8, 2022 17:54
Signed-off-by: Yingrong Zhao <[email protected]>
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring out how to get past those weird go mod errors! 👍

@@ -24,7 +24,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: 1.17
go-version: 1.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to change anything but I wanted to show you a nice improvement to this gh action in their latest v3 release that uses the go version defined in your go.mod and it automatically sets up caching too

- uses: actions/setup-go@v3
   with:
     go-version-file: go.mod
     cache: true
     cache-dependency-path: go.sum

@carolynvs carolynvs merged commit 49e4cfe into getporter:main Sep 8, 2022
@carolynvs carolynvs mentioned this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants