Bump porter to 1.0.1 #183
Merged
Bump porter to 1.0.1 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
carolynvs
commented
Oct 17, 2022
•
carolynvs
commented
- Update to Go 1.19
- Build against porter 1.0.1
- Update the schema of resources for the latest version of porter
carolynvs
force-pushed
the
bump-porter
branch
2 times, most recently
from
c7cff6a to
314473e
Compare
* Update to Go 1.19 * Build against porter 1.0.1 Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
bump-porter
branch
from
314473e to
4267012
Compare
Signed-off-by: Carolyn Van Slyck <[email protected]>
sgettys
reviewed
Oct 20, 2022
| @@ -405,7 +405,7 @@ type PorterCfgOpts struct { | |||
| SecretsNamespace string | |||
| } | |||
|
|
|||
| //NewPorterCofnig GetDefaultPorterConfig - DefaultStorage, DefaultSecretsPlugin and DefaultStorageConfig set. We tweak DefaultSecrets and SecretsConfig as needed | |||
| // NewPorterCofnig GetDefaultPorterConfig - DefaultStorage, DefaultSecretsPlugin and DefaultStorageConfig set. We tweak DefaultSecrets and SecretsConfig as needed | |||
There was a problem hiding this comment.
If we're in here touching this might as well fix the typo :)
There was a problem hiding this comment.
Hah, oops I am just awful at spotting typos. 👍
sgettys
approved these changes
Oct 20, 2022
Signed-off-by: Carolyn Van Slyck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.