V1.0.0-support #88
Merged
V1.0.0-support #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian DeGeeter <[email protected]>
bdegeeter
force-pushed
the
v1.0.0-support
branch
from
2bef2c0 to
e7b820f
Compare
|
@bdegeeter When you are ready for a review, just flip this out of draft status. 👍 |
Signed-off-by: Brian DeGeeter <[email protected]>
Signed-off-by: Brian DeGeeter <[email protected]>
Signed-off-by: Brian DeGeeter <[email protected]>
bdegeeter
requested review from
carolynvs,
vdice and
simongdavies
as code owners
|
I've got a WIP github actions pipeline. It's disabled for now and I'll come back to it after addressing any feedback on this PR. |
carolynvs
reviewed
Mar 28, 2022
carolynvs
reviewed
Mar 28, 2022
carolynvs
reviewed
Mar 28, 2022
sgettys
force-pushed
the
v1.0.0-support
branch
2 times, most recently
from
bde2e03 to
0bd51a3
Compare
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Brian DeGeeter <[email protected]>
Signed-off-by: Brian DeGeeter <[email protected]>
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Brian DeGeeter <[email protected]>
Signed-off-by: Brian DeGeeter <[email protected]>
carolynvs
reviewed
Apr 7, 2022
|
After this is merged, would you be interested in being added as maintainers to this repository? You will know it as well as anyone at that point and I would love the help. |
Signed-off-by: Steven Gettys <[email protected]>
carolynvs
reviewed
Apr 7, 2022
Signed-off-by: Steven Gettys <[email protected]>
carolynvs
approved these changes
Apr 8, 2022
This is great, thank you so much for redoing the plugin to work with the porter v1 and the latest operator!
|
Oops, can you resolve the conflict on go.mod/go.sum and then I'll merge? |
Signed-off-by: Steven Gettys <[email protected]>
|
@carolynvs resolved conflicts |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Steven Gettys <[email protected]>
|
/azp run |
|
Commenter does not have sufficient privileges for PR 88 in repo getporter/kubernetes-plugins |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Steven Gettys <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update k8s secrets plugin for porter v1.0.0.