Only download porter runtime when porter changes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was checking if the porter-runtime version matched the desired version and completely forgot that check will _only_ pass on linux. So on most local dev machines, win/mac, it was always downloading the runtime each build because the version check failed. You can't check the version when the architecture is a mismatch... I've updated the EnsurePorter logic so that we download the runtime binary when: * It's missing * We downloaded the client This way repeated builds won't re-download anything, but if the change the desired client version that will force the runtime to download too. Signed-off-by: Carolyn Van Slyck <[email protected]>
VinozzZ
reviewed
Jan 11, 2023
porter/porter_test.go
Outdated
|
|
||
| // when the runtime binary already exists, leave it | ||
| t.Run("runtime binary only downloaded when client is stale", func(t *testing.T) { | ||
| tmp, err := os.MkdirTemp("", "magefiles") |
There was a problem hiding this comment.
nit - we can use t.TempDir here to have it being automatically cleaned up
Signed-off-by: Carolyn Van Slyck <[email protected]>
|
@VinozzZ Fixed, please take a look |
VinozzZ
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the EnsurePorter helper so that the porter-runtime binary isn't constantly re-downloaded on a mac/win dev machine. I was trying to download only when the version was out of date but that can't be reliably checked on all platforms since the runtime binary is always linux. So the version check was failing every time (and causing a download).
I've updated the EnsurePorter logic so that we download the runtime binary when:
This way repeated builds won't re-download anything, but if the change the desired client version that will force the runtime to download too.