Skip to content

Commit

Permalink
Log into docker before running integration tests
Browse files Browse the repository at this point in the history
The updated TestRegistry test in the integration test suite requires that the user is logged into docker in order to work properly. I have updated the integration build so that it logs into the docker hub registry before running the integration tests. Because this is not safe to run for un-reviewed code, I have also updated the integration build to require a comment from a maintainer before running.

So you will need to manually trigger the integration tests before merging a PR with `azp run porter-integration`.

Signed-off-by: Carolyn Van Slyck <[email protected]>
  • Loading branch information
carolynvs committed Sep 20, 2022
1 parent 8faa53a commit 4367243
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions build/azure-pipelines.integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,13 @@ stages:
displayName: "Configure Agent"
- bash: mage build
displayName: "Native Build"
# We log in here because TestRegistry integration test needs a valid docker session
# This unfortunately means that this pipeline must be manually triggered for non-maintainers
- task: Docker@1
displayName: Docker Login
inputs:
containerRegistryType: Container Registry
dockerRegistryEndpoint: docker.io/getporter
command: login
- bash: mage -v TestIntegration
displayName: "Integration Test"

0 comments on commit 4367243

Please sign in to comment.