Add linter success message (#2274)

getporter · Aug 2, 2022 · afcd5de · afcd5de
1 parent da2106d
commit afcd5de
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/pkg/porter/lint.go b/pkg/porter/lint.go
@@ -71,6 +71,11 @@ func (p *Porter) PrintLintResults(ctx context.Context, opts LintOptions) error {
 		return err
 	}
 
+	if !results.HasError() {
+		fmt.Fprintln(p.Out, "✨ Bundle validation was successful!")
+		return nil
+	}
+
 	switch opts.Format {
 	case printer.FormatPlaintext:
 		fmt.Fprintln(p.Out, results.String())

diff --git a/pkg/porter/lint_test.go b/pkg/porter/lint_test.go
@@ -93,9 +93,11 @@ exec:
 	testcases := []struct {
 		format         string
 		wantOutputFile string
+		linterResults  linter.Results
 	}{
-		{"plaintext", "testdata/lint/results.txt"},
-		{"json", "testdata/lint/results.json"},
+		{"plaintext", "testdata/lint/results.txt", lintResults},
+		{"json", "testdata/lint/results.json", lintResults},
+		{"plaintext", "testdata/lint/success.txt", linter.Results{}},
 	}
 	for _, tc := range testcases {
 		t.Run(tc.format, func(t *testing.T) {
@@ -105,7 +107,7 @@ exec:
 			p.TestConfig.TestContext.AddTestFile("testdata/porter.yaml", "porter.yaml")
 
 			mixins := p.Mixins.(*mixin.TestMixinProvider)
-			mixins.LintResults = lintResults
+			mixins.LintResults = tc.linterResults
 
 			var opts LintOptions
 			opts.RawFormat = tc.format

diff --git a/pkg/porter/testdata/lint/success.txt b/pkg/porter/testdata/lint/success.txt
@@ -0,0 +1 @@
+✨ Bundle validation was successful!